Skip to content

Conversation

@dbpolito
Copy link
Member

@dbpolito dbpolito commented Apr 29, 2025

This pull request introduces improvements to the CI/CD workflow and simplifies the Docker images for multiple PHP-Nginx versions by replacing manual installation of supervisord with package manager installation and adding a new supervisor.conf configuration file.

CI/CD Workflow Updates:

  • Added pull_request as a trigger in the CI/CD workflow configuration to enable testing for pull requests. (.github/workflows/ci-cd.yml, .github/workflows/ci-cd.ymlR6)

Dockerfile Simplifications:

  • Replaced the manual download and installation of supervisord with its installation via the package manager (apk add --no-cache nginx supervisord) across all PHP-Nginx versions (8.0, 8.1, 8.2, 8.3, 8.4) for both -prod and non--prod variants. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

Supervisor Configuration:

  • Added a supervisor.conf file for all PHP-Nginx versions (8.0, 8.1, 8.2, 8.3, 8.4) to configure supervisord with logging to stdout and to run in no-daemon mode. This ensures better integration with containerized environments.

@dbpolito dbpolito requested a review from fabriciojs April 29, 2025 16:10
@dbpolito dbpolito requested a review from Copilot April 29, 2025 16:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI/CD workflow configuration by adding a pull_request trigger to the workflow events.

  • Added pull_request event under the workflow triggers in the CI/CD configuration
Files not reviewed (19)
  • 8.0-nginx-prod/Dockerfile: Language not supported
  • 8.0-nginx-prod/supervisor.conf: Language not supported
  • 8.0-nginx/Dockerfile: Language not supported
  • 8.0-nginx/supervisor.conf: Language not supported
  • 8.1-nginx-prod/Dockerfile: Language not supported
  • 8.1-nginx-prod/supervisor.conf: Language not supported
  • 8.1-nginx/Dockerfile: Language not supported
  • 8.1-nginx/supervisor.conf: Language not supported
  • 8.2-nginx-prod/Dockerfile: Language not supported
  • 8.2-nginx-prod/supervisor.conf: Language not supported
  • 8.2-nginx/Dockerfile: Language not supported
  • 8.2-nginx/supervisor.conf: Language not supported
  • 8.3-nginx-prod/Dockerfile: Language not supported
  • 8.3-nginx-prod/supervisor.conf: Language not supported
  • 8.3-nginx/Dockerfile: Language not supported
  • 8.3-nginx/supervisor.conf: Language not supported
  • 8.4-nginx-prod/Dockerfile: Language not supported
  • 8.4-nginx-prod/supervisor.conf: Language not supported
  • 8.4-nginx/Dockerfile: Language not supported

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 10 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fabriciojs fabriciojs merged commit 63b8cde into master Jan 25, 2026
18 checks passed
@fabriciojs fabriciojs deleted the supervisord branch January 25, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants